[RNMobile] Add media caption when adding an image or video #28469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the video already has a caption value it will added in the block.
fluiddot
added
[Type] Bug
fluiddot
added
[Type] Enhancement
2 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
This was referenced Jan 26, 2021
Closed
|
Hi @fluiddot since I am reviewing the associated WP Android and FluxC PRs I was thinking to add myself as a reviewer here? Just to verify, do you want me to take a look at these changes as yet? Let me know your thoughts. Thank you. |
👋 @jd-alexander yeah it would be nice if you assign yourself as a reviewer in this PR. I was waiting for the native PRs to be ready because potential changes there might imply to update this part but I'd appreciate feedback here too, thanks! |
There was a problem hiding this comment.
Thanks for these changes @fluiddot Things are looking good so far. The only blocker for merging in these changes from an Android point of view is that the caption value is not being propagated on the jetpack and Atomic sites. I started looking into the Jetpack code and I found one of the places see where the value of the caption is being passed via the Jetpack functions that represent all requests/responses for external media.
I am going to some more diagnostics from the HTTP layer soon to see if I can figure out what's happening.
|
So the results from my checks so far are as follows:
Is this behavior also taking place on iOS? |
Yeah that's the issue I spotted while testing and I also have the impression that is related to that endpoint. However it can only be reproduced on sites connected with Jetpack, the same endpoint on WP.com regular sites returns the caption on the JSON result 🤔 . On iOS this is not happening because it doesn't use the I'll keep investigating the issue just in case it's something related to Jetpack, if that's case I'll open an issue there with the insights. |
Indeed! I realized this as well.
Makes sense
Yes, that's a good idea. |
|
Doing some cleanup to old PRs. This draft PR seems staled. Is it still relevant, should we close it? |
No, no longer relevant. I'll close it, thanks for the heads up 🙇 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg-mobileWordPress-iOSWordPress-AndroidWordPress-FluxC-AndroidDescription
This PR addresses the following topics:
Upload credit/attribution of photos from free photo library
The idea is to upload as the caption of the media item the credit/attribution from photos that we get from the free photo library (Pexels). The changes for this have been applied in the native projects (iOS and Android).
Include caption of media items when inserting them into a block
This covers the Image and Video block.
How has this been tested?
Image
The following steps are for iOS version but they're very similar on Android.
+button.Imageblock.ADD IMAGE.Free Photo LibraryVideo
The following steps are for iOS version but they're very similar on Android.
For this flow a site with a premium plan is required.
+button.Choose from My devicebutton.+button.Videoblock.ADD VIDEO.WordPress Media LibraryScreenshots
Types of changes
Bug fix
Checklist: